Remove openai latest dep restriction #14423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Aug 14, 2025
| } | ||
| return Value.of(result); | ||
| } | ||
|
|
||
| @Nullable | ||
| private static Value<String> toValue(@Nullable String string) { |
There was a problem hiding this comment.
IIUC, we have null handling here because of the very rare situation where reflection fails for some reason - this is despite also having nice isAvailable checks.
Any thoughts on having invokeStringHandle return "" in the failure case since we expect it to basically not happen?
Otherwise, it's probably worth adding a comment summarizing the above to clarify this is an issue with the code here and not the API responses
anuraaga
approved these changes
Aug 15, 2025
jaydeluca
approved these changes
Aug 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @anuraaga